TestRoomState: use non-default power levels to test powerlevels event retrieval#600
Open
sumnerevans wants to merge 1 commit intomatrix-org:mainfrom
Open
TestRoomState: use non-default power levels to test powerlevels event retrieval#600sumnerevans wants to merge 1 commit intomatrix-org:mainfrom
sumnerevans wants to merge 1 commit intomatrix-org:mainfrom
Conversation
… retrieval Signed-off-by: Sumner Evans <sumner@beeper.com>
squahtx
reviewed
Feb 7, 2023
Comment on lines
+83
to
+85
| // An empty users map should get merged with the default | ||
| // events map which will include the creator as an admin. | ||
| "users": map[string]interface{}{}, |
Contributor
There was a problem hiding this comment.
Synapse is not doing any merging and failing the test as a result. If I remember rightly, the spec is a little unclear about whether merging should happen.
Contributor
Author
There was a problem hiding this comment.
Yep, I mentioned that here: matrix-org/matrix-spec#492 (comment)
Synapse only merges one level deep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sumner Evans sumner@beeper.com
Pull Request Checklist